commonjs-dynamic-required modules are not transformed by plugin-babel

[JLHwung]

• Rollup Plugin Name: commonjs, babel
• Rollup Plugin Version: 21.0.1, 5.3.0
• Rollup Version: 2.63.0
• Operating System (or Browser): macOS
• Node Version: 17.3.0
• Link to reproduction (⚠️ read below): https://github.com/JLHwung/rollup-commonjs-dynamic-register-not-transformed-by-plugin-babel

Reproduction steps:

pnpm i
pnpm test

Expected Behavior

It should contain the transformed module module.exports = { a: a };

Actual Behavior

It contains module.exports = { a };, in other words, the imported module is not transformed by plugin-babel

Additional Information

The dynamic-required-proxied modules have a wrapped id starting with \0. After they are loaded by the DynamicRequireProxy, they are not transformed by plugin-babel because any id containing \0 is rejected by pluginutils/createFilter.

The dynamic required targets are client files, I believe they should be transformed by plugin-babel and any other transformers. A potential solution is to change how the dynamic required targets id are determined.

This issue blocks babel/babel#14112. In that case, we use plugin-commonjs to load https://github.com/mathiasbynens/regenerate-unicode-properties. Each unicode properties script contains const set = regenerate() and they not transformed by the plugin-babel.

[shellscape]

Do we need to come up with more sophisticated means to tag virtual modules, perhaps with metadata?

[lukastaegert]

I guess I need to finish #1038 as that will just get rid of all the dynamic register logic.

[lukastaegert]

BTW as long as you do not rely on watch mode, the current @rollup/plugin-commonjs@beta should work well and likely solve all issues.

[JLHwung]

@lukastaegert Yes. I can confirm @beta work for Babel. babel/babel#14124

This issue can be closed once #1038 is merged. Can you update the PR info?

[stale]

Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it. ⓘ