Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Parsing correctly? #172

Closed
robert-blair opened this issue Mar 7, 2017 · 2 comments
Closed

Parsing correctly? #172

robert-blair opened this issue Mar 7, 2017 · 2 comments

Comments

@robert-blair
Copy link

Im trying to run roll-up in tandem with the angular aot compiler, the aot works fine but when I try to run roll-up it says that there's an unexpected error in an rxjs file, but I don't think it's there??

Could there be something wrong with the parser?

screenshot

import rollup      from 'rollup'
import nodeResolve from 'rollup-plugin-node-resolve'
import commonjs    from 'rollup-plugin-commonjs';
import uglify      from 'rollup-plugin-uglify'


export default {
  entry: 'src/main-aot.js',
  dest: 'aot/dist/build.js',
  sourceMap: true,
  sourceMapFile: 'aot/dist/build.js.map',
  format: 'iife',
  onwarn: function(warning) {
    
    if ( warning.code === 'THIS_IS_UNDEFINED' ) { return; }
    if ( warning.indexOf("The 'this' keyword is equivalent to 'undefined'") > -1 ) { return; }


    console.warn( warning.message );
  },
  
  plugins: [
    nodeResolve({jsnext: true, module: true}),
    commonjs({include: ['node_modules/rxjs/**']}),
    uglify()
  ]
}
@Rich-Harris
Copy link
Contributor

I think this might have been fixed by #170 — could you try reinstalling this plugin and seeing if it's still an issue? Thanks

@robert-blair
Copy link
Author

Yup that fixed it.

Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants