This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
Allow named entrypoints #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2018
lukastaegert
approved these changes
Aug 9, 2018
There was a problem hiding this comment.
Thanks a lot! Sorry this has been waiting for some time. As this includes a test but basically solves the same issue as #322, I will give this one preference.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
experimentalCodeSplittingflag turned on, rollup allows multiple entrypoints in array form (already supported by this plugin) and as an object (see here: https://rollupjs.org/guide/en#core-functionality - subsection input) representing named entrypoints (currently not supported by this plugin).Since we have a high demand on this feature on our project, I'd like to contribute back the necessary changes to make objects as multiple entrypoints work with this plugin.
I added a test for this extra feature and made sure that all other tests are still working as expected.
To make the tests work with this form of entrypoints I had to update your devDependency of Rollup to 0.63.2 (latest at the current time).
Regards,
Jonas