Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mongo::Struct constructor_type is broken #24

Open
v-kolesnikov opened this issue Dec 24, 2017 · 1 comment · May be fixed by #25
Open

Mongo::Struct constructor_type is broken #24

v-kolesnikov opened this issue Dec 24, 2017 · 1 comment · May be fixed by #25

Comments

@v-kolesnikov
Copy link

Hi, folks!

I assume ROM::Mongo::Struct was broken after this commit: https://github.com/dry-rb/dry-struct/pull/55/files

rom-mongo/lib/rom/mongo/struct.rb

Lines 4 to 8 in cc335a4

module Mongo
class Struct < ROM::Struct
constructor_type :symbolized
end
end

I think we can just remove this option and inherit :permissive option from ROM::Struct.
I would love to make PR as well.

@solnic @GustavoCaso
@GustavoCaso
Copy link
Member

Yes @v-kolesnikov with the latest version of dry-struct this will raise an error.

I haven't use rom-mongo ever but I think what you are suggesting is a good idea.

@v-kolesnikov v-kolesnikov linked a pull request Dec 28, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix upgrading to ROM 4.x v-kolesnikov/rom-mongo
2 participants
@GustavoCaso @v-kolesnikov