Cancel throws exception

[ralph-bergmann]

When the user cancels a scan, an exception is thrown. I'm unsure if this is good behavior because canceling is an allowed operation and should not throw an exception.

see https://github.com/roman-yerin/native_qr/blob/trunk/android/src/main/kotlin/team/ion/native_qr/NativeQrPlugin.kt#L40

[ralph-bergmann]

At least you should make a difference between a canceled scan and a scan with a failure. Currently, both are throwing an exception, and both have the same message "canceled".

[roman-yerin]

That's because of the oversimplified Flutter plugin interface.

Currently, both are throwing an exception, and both have the same message "canceled".

You're right.

[ralph-bergmann]

At least with Pigeon you can implement some return Types like: ScanResult, ScanCanceld and ScanFailure.

[roman-yerin]

Thanks for your suggestion, Ralph, I appreciate it.
As some people asked to implement barcodes and non-string raw QR codes, your proposal is highly likely a step into the same way.