Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Add simpleCompareImages() method #119

Open
romankh3 opened this issue Jun 15, 2019 · 3 comments
Open

[IMPROVEMENT] Add simpleCompareImages() method #119

romankh3 opened this issue Jun 15, 2019 · 3 comments
Assignees
@romankh3
Labels
enhancement New feature or request

Comments

@romankh3
Copy link
Owner

** Describe your idea of the improvement **
to make it faster it's good to have the ability to exclude drawing rectangles with the differences.
@romankh3 romankh3 added the enhancement New feature or request label Jun 15, 2019
@romankh3 romankh3 self-assigned this Jun 15, 2019
@romankh3
Copy link
Owner Author

It doesn't make faster as it expected. Move to a backlog.

@MrMisterG
Copy link

I think this issue means, upon the first found different pixel, the compare-pixel loop is exited and comparisonState gets changed to MISMATCH. Maybe then it's faster.

@romankh3
Copy link
Owner Author

romankh3 commented Dec 9, 2019

you're right. That's the idea

This was referenced Apr 18, 2022
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romankh3 romankh3

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romankh3 @MrMisterG