Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Semicolon vs colons in TypeScript types #2404

Closed
Tracked by #2403
MichaReiser opened this issue Apr 13, 2022 · 5 comments · Fixed by #2412
Closed
Tracked by #2403

Semicolon vs colons in TypeScript types #2404

MichaReiser opened this issue Apr 13, 2022 · 5 comments · Fixed by #2412
Labels
A-Formatter Area: formatter good first issue Good for newcomers

Comments

@MichaReiser
Copy link
Contributor

MichaReiser commented Apr 13, 2022

Description

Rome uses , to separate interface or object type literal members whereas prettier uses ;

// Prettier
type X = {
  a: string;
  b: number;
}

// Rome
type X = {
  a: string,
  b: number,
}

Proposal

Change Rome to use semicolons. Personally, I prefer commas but I adopted prettier's style and I'm fine with it.

by @cpojer

Playground

@MichaReiser MichaReiser added good first issue Good for newcomers A-Formatter Area: formatter labels Apr 13, 2022
@ematipico
Copy link
Contributor

This will be easy to implement, I will take care of it

@ematipico ematipico self-assigned this Apr 13, 2022
@MichaReiser
Copy link
Contributor Author

Just keep in mind that this would be a perfect first issue (part of the reason why I spent so much time writing this up ;))

@ematipico
Copy link
Contributor

Sorry, I didn't see any label but it's actually true! Let's do that

@ematipico ematipico removed their assignment Apr 13, 2022
@ematipico
Copy link
Contributor

@cpojer
Copy link
Contributor

cpojer commented Apr 13, 2022

Sorry, I need this fixed. I reported it, so I fixed it :P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Formatter Area: formatter good first issue Good for newcomers
Projects
Status: Done
3 participants