This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 659
Semicolon vs colons in TypeScript types #2404
Labels
Comments
45 tasks
MichaReiser
added
good first issue
Good for newcomers
A-Formatter
Area: formatter
labels
Apr 13, 2022
This will be easy to implement, I will take care of it |
Just keep in mind that this would be a perfect first issue (part of the reason why I spent so much time writing this up ;)) |
Sorry, I didn't see any label but it's actually true! Let's do that |
For whoever wants to contribute: https://github.com/rome/tools/blob/main/crates/rome_js_formatter/src/ts/lists/type_member_list.rs#L24-L31 |
Sorry, I need this fixed. I reported it, so I fixed it :P |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Rome uses
,
to separateinterface
or object type literal members whereas prettier uses;
Proposal
Change Rome to use semicolons. Personally, I prefer commas but I adopted prettier's style and I'm fine with it.
by @cpojer
Playground
The text was updated successfully, but these errors were encountered: