Break first binary expression group exceeding line width

[MichaReiser]

Rome's formatter doesn't break the right-hand side of a binary expression to a new line if the left expression and the operator together exceed the line width.

It works as expected if the binary expression is nested. Playground

Input

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa+ 1;

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa+ 1 + 2;

Prettier

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +
	1;

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +
	1 +
	2;

Rome

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa + 1;

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +
	1 +
	2;

Expected

Consistent formatting of binary expression regardless if a binary expression is nested or not.
Formatted source matches Prettiers output.

[ematipico]

The issue is that when we have binary like expressions of only two items, we hard group: https://github.com/rome/tools/blob/main/crates/rome_js_formatter/src/utils/binary_like_expression.rs#L239-L246

An hard group doesn't break in this particular case. On the other hand, if we just use a group, we might bump into some issue where 1 + 1 breaks on multiple lines.

We have to have access to the width

[ematipico]

No need to access to the width. Probably using a group instead of an hard group might fix the issue. Also using conditional content such as if_group_breaks might help to reach the solution.

Still, this is a hot path and the code is quite big, so the that's why it's difficult.

[MichaReiser]

This works as expected in the latest version of Rome: Playground