Named imports formatting

[MichaReiser]

Prettier breaks the named imports if the whole import statements exceed the line width, Rome only does so if the named imports exceed the line width Playground

Input

import somethingSuperLongsomethingSuperLong from 'somethingSuperLongsomethingSuperLongsomethingSuperLong'
import {somethingSuperLongsomethingSuperLong1} from 'somethingSuperLongsomethingSuperLongsomethingSuperLong'
import a234556666666, {somethingSuperLongsomethingSuperLong2} from 'somethingSuperLongsomethingSuperLongsomethingSuperLong'
import {a234556666666dddddddddddddddddd, somethingSuperLongsomethingSuperLong3} from 'somethingSuperLongsomethingSuperLongsomethingSuperLong'

Prettier

import somethingSuperLongsomethingSuperLong from "somethingSuperLongsomethingSuperLongsomethingSuperLong";
import { somethingSuperLongsomethingSuperLong1 } from "somethingSuperLongsomethingSuperLongsomethingSuperLong";
import a234556666666, {
  somethingSuperLongsomethingSuperLong2,
} from "somethingSuperLongsomethingSuperLongsomethingSuperLong";
import {
  a234556666666dddddddddddddddddd,
  somethingSuperLongsomethingSuperLong3,
} from "somethingSuperLongsomethingSuperLongsomethingSuperLong";

Rome

import somethingSuperLongsomethingSuperLong from "somethingSuperLongsomethingSuperLongsomethingSuperLong";
import { somethingSuperLongsomethingSuperLong1 } from "somethingSuperLongsomethingSuperLongsomethingSuperLong";
import a234556666666, { somethingSuperLongsomethingSuperLong2 } from "somethingSuperLongsomethingSuperLongsomethingSuperLong";
import {
  a234556666666dddddddddddddddddd,
  somethingSuperLongsomethingSuperLong3,
} from "somethingSuperLongsomethingSuperLongsomethingSuperLong";

Expected

Rome's formatting to match Prettier's

[IWANABETHATGUY]

I translate the format IR to rust code as below,

use rome_formatter::{
    format_element::ConditionalGroupContent, hard_line_break, indent, soft_block_indent,
    soft_line_break_or_space, space_token, LineWidth,
};

fn main() {
    use rome_formatter::{
        format_elements, group_elements, soft_line_break, token, FormatOptions, Formatted,
    };

    let elements = group_elements(format_elements![
        token("{"),
        soft_block_indent(format_elements![
            soft_line_break_or_space(),
            token("somethingSuperLongsomethingSuperLong2"),
            // space_token(),
            ConditionalGroupContent::new(
                token(","),
                rome_formatter::format_element::GroupPrintMode::Multiline
            )
        ]),
        token("}"),
        space_token(),
        token("from"),
        space_token(),
        token("\"somethingSuperLongsomethingSuperLongsomethingSuperLong\""),
        token(";"),
    ]);

    //     List [
    //     SyntaxTokenSlice("import"),
    //     Space,
    //     SyntaxTokenSlice("ww"),
    //     SyntaxTokenSlice(","),
    //     Space,
    //     Group(
    //         List [
    //             SyntaxTokenSlice("{"),
    //             Indent(
    //                 List [
    //                     Line(SoftOrSpace),
    //                     SyntaxTokenSlice("somethingSuperLongsomethingSuperLong2"),
    //                     ConditionalGroupContent {
    //                         content: StaticToken(","),
    //                         mode: Multiline,
    //                     },
    //                 ],
    //             ),
    //             Line(SoftOrSpace),
    //             SyntaxTokenSlice("}"),
    //         ],
    //     ),
    //     Space,
    //     SyntaxTokenSlice("from"),
    //     Space,
    //     DynamicToken("\"somethingSuperLongsomethingSuperLongsomethingSuperLong\""),
    //     StaticToken(";"),
    //     SyntaxTokenSlice(""),
    //     Line(Hard),
    // ]
    let elements = format_elements![
        token("import"),
        space_token(),
        token("ww"),
        token(","),
        space_token(),
        elements,
        // hard_line_break()
    ];
    println!(
        "{}",
        Formatted::new(elements, FormatOptions::default())
            .print()
            .as_code()
    );
    // assert_eq!(
    //     "a,b",
    //     Formatted::new(elements, FormatOptions::default())
    //         .print()
    //         .as_code()
    // );
}

It prints

import ww, {
        somethingSuperLongsomethingSuperLong2,
} from "somethingSuperLongsomethingSuperLongsomethingSuperLong";

when I adjust format_width to 114 it prints

import ww, { somethingSuperLongsomethingSuperLong2} from "somethingSuperLongsomethingSuperLongsomethingSuperLong";

it should be the same as prettier, but I don't know how to apply it to our formatter code.

[IWANABETHATGUY]

#2498
I make a draft here, could you help me find what I did wrong?