Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 useSimplifiedLogicExpression removes comments in its code action #3527

Open
1 task done
ematipico opened this issue Oct 28, 2022 · 0 comments
Open
1 task done

🐛 useSimplifiedLogicExpression removes comments in its code action #3527

ematipico opened this issue Oct 28, 2022 · 0 comments
Labels
A-Linter Area: linter S-Bug: confirmed Status: report has been confirmed as a valid bug
Milestone
10.0.0

Comments

@ematipico
Copy link
Contributor

Environment information

Test run while using branch `feature/promote-rules-v2`

What happened?

Check the playground

Expected result

The suggested fix should not remove the comments

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@ematipico ematipico added S-To triage Status: user report of a possible bug that needs to be triaged S-Bug: confirmed Status: report has been confirmed as a valid bug A-Linter Area: linter and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Oct 28, 2022
@ematipico ematipico self-assigned this Oct 28, 2022
@ematipico ematipico added this to the 10.0.0 milestone Oct 28, 2022
@ematipico ematipico mentioned this issue Oct 28, 2022
Closed
@ematipico ematipico removed their assignment Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Linter Area: linter S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
Rome 2022
Status: No status
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

fix(rome_js_analyze): keep comments when simplifying logical expression rome/tools
1 participant
@ematipico