Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 IIFE semi #4553

Closed
1 task done
izayl opened this issue Jun 7, 2023 · 4 comments · Fixed by #4576
Closed
1 task done

🐛 IIFE semi #4553

izayl opened this issue Jun 7, 2023 · 4 comments · Fixed by #4576
Assignees
Labels
A-Linter Area: linter S-Bug: confirmed Status: report has been confirmed as a valid bug

Comments

@izayl
Copy link

izayl commented Jun 7, 2023

Environment information

CLI:
  Version:                      12.1.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.12.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/8.19.2"

Rome Configuration:
  Status:                       unset

Workspace:
  Open Documents:               0

Discovering running Rome servers...

What happened?

playground: https://docs.rome.tools/playground/?lineWidth=120&indentStyle=space&semicolons=as-needed&code=KAAoACkAPQA%2BACAAewB9ACkAKAApAA%3D%3D

format add ; before IIFE, but linter not allow

Expected result

when Semicolons sets to AsNeeded, it should allow ; before IIFE

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@izayl izayl added the S-To triage Status: user report of a possible bug that needs to be triaged label Jun 7, 2023
@Conaclos Conaclos added S-Bug: confirmed Status: report has been confirmed as a valid bug A-Linter Area: linter and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Jun 7, 2023
@ematipico
Copy link
Contributor

@izayl how can we replicate the issue? When I open the playground, I don't see any errors or diagnostics

@izayl
Copy link
Author

izayl commented Jun 12, 2023

@ematipico add ; to the start cursor of first line

@ematipico
Copy link
Contributor

Thank you!

@Conaclos I am a bit conflicted here. From my point of view, I think we should remove this lint rule because we have the formatter that takes care of it. We wouldn't want to create conflicts among tools. What's your take?

@Conaclos
Copy link
Contributor

I am a bit conflicted here. From my point of view, I think we should remove this lint rule because we have the formatter that takes care of it.

I agree. I will open a PR to remove it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants