Skip to content
This repository has been archived by the owner on Oct 13, 2019. It is now read-only.

Feed fetching #7

Closed
mishako opened this issue Aug 3, 2017 · 4 comments
Closed

Feed fetching #7

mishako opened this issue Aug 3, 2017 · 4 comments

Comments

@mishako
Copy link
Member

mishako commented Aug 3, 2017

Pros

  • Easier for users to try the library out

Cons

  • Need external library
  • Takes development and support time

I was thinking maybe we can detect if there is a supported HTTP library on the classpath. For example apache or jersey, or okhttp. If there is no library we throw an exception. Modern HTTP libraries are very easy to use, so it shouldn't be hard to support several of them.

If we decide to expose a simple fetch(String url), we need to somehow be explicit that it's only intended to be used for most basic use cases. Otherwise we will be flooded with questions like "why doesn't it work for website X?" or "how can I send custom headers?".

@mishako mishako mentioned this issue Aug 3, 2017
9 tasks
@PatrickGotthard
Copy link
Member

Because modern HTTP libraries are so easy to use I would not support fetching feeds. This is something our users should definitely be able to do themselves.

@imk
Copy link

imk commented Aug 3, 2017

👍 for restricting feed fetching to most basic use cases, there are enough libs focused on http requests.

But we could add some read methods for some response types (like apache httpclient, okhttp etc) for convenience, so users can make the request however they want, by getting the response in Rome, we would have access to headers like charset etc, could be helpful when parsing the feed.

@mishako
Copy link
Member Author

mishako commented Aug 3, 2017

I like the idea of providing some support for response types. Similarly to how jackson makes it easy to deserialize jaxrs responses with jackson-jaxrs-providers.

@mishako
Copy link
Member Author

mishako commented Aug 18, 2017

Okay, I think we have a decision: no built-in fetching in Rome 2. Some support for existing http libraries can be convenient, but is a nice-to-have. We can think about it later.

@mishako mishako closed this as completed Aug 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants