Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing of UndefInitializer() #170

Closed
bkamins opened this issue May 18, 2022 · 7 comments
Closed

Printing of UndefInitializer() #170

bkamins opened this issue May 18, 2022 · 7 comments

Comments

@bkamins
Copy link

bkamins commented May 18, 2022

Is this intended?

julia> [undef]
1-element Vector{UndefInitializer}:
 UndefInitializer(): array initializer with undefined values

julia> PrettyTables.pretty_table([undef])
┌────────┐
│ Col. 1 │
├────────┤
│ #undef │
└────────┘

The output confuses users as they think the first element of the vector is undefined, while it is defined and is a valid UndefInitializer() value.

@ronisbr
Copy link
Owner

ronisbr commented May 18, 2022

Good point! Thanks @bkamins . I will see how can I fix this. The problem is that I am replacing undefined cells with undef internally. I will probably need to create a custom internal variable for this.

@bkamins
Copy link
Author

bkamins commented May 18, 2022

I will probably need to create a custom internal variable for this.

Yes - I think custom type should be used.

@ronisbr
Copy link
Owner

ronisbr commented May 18, 2022

Ok! This modification is breaking, because if someone is overloading how #undef is shown by default, then it will not work anymore. I will release together with the code I am preparing that adds / modifies what we need to print DataFrames in LaTeX and HTML. My only problem is the unusual amount of work I am getting nowadays 😄 Sorry for the delay, but I am working on it.

@bkamins
Copy link
Author

bkamins commented May 18, 2022

Sure - no rush. This is a minor issue for DataFrames.jl. Thank you for the support!

@bkamins
Copy link
Author

bkamins commented Jun 20, 2022

bump (just to be sure if it is tracked - thank you!)

@ronisbr
Copy link
Owner

ronisbr commented Jun 21, 2022

Yes, it is :) I am struggling with divs in HTML backend... They do not play nice in Jupyter as I thought they will be...

@bkamins
Copy link
Author

bkamins commented Jun 21, 2022

I know (HTML is hard ...). Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants