-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings are displayed when roo is used with Ruby 3.3.0 #604
Comments
Hi @mark-young-atg |
Hi @sydverisk |
While this is, correctly, not a compatibility issue, it will be for supporting Ruby 3.4.0. The issue stems from a change in what gems (csv and base64, in this case), are included by default in the Ruby standard library. Meaning, that we will have errors beginning in Ruby 3.4. |
Steps to reproduce
Running code that uses the roo gem with Ruby 3.3.0 causes the following warnings to be shown
.../gems/roo-2.10.0/lib/roo/open_office.rb:9: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of roo-2.10.0 to add base64 into its gemspec.
.../gems/roo-2.10.0/lib/roo/csv.rb:3: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of roo-2.10.0 to add csv into its gemspec.
Issue
This is a deprecation warning that has been added to Ruby 3.3.0 and which will cause roo to fail if run with Ruby 3.4
https://rubyreferences.github.io/rubychanges/3.3.html#gems-that-are-warned-to-become-bundled-in-the-next-version
System configuration
Roo version: 2.10.0
Ruby version: 3.3.0
Further notes
I initially intended to create a PR for this by adding the following to the roo.gemspec file:
However that caused the
rspec
tests to fail. So I bailed and created this issue instead.The text was updated successfully, but these errors were encountered: