Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm Charts - Separate image into repository and tag #13585

Closed
krishau99 opened this issue Jan 18, 2024 · 5 comments · Fixed by #14014
Closed

Helm Charts - Separate image into repository and tag #13585

krishau99 opened this issue Jan 18, 2024 · 5 comments · Fixed by #14014
Labels

Comments

@krishau99
Copy link

Is this a bug report or feature request?

  • Feature Request

What should the feature do:

The feature should separate the helm value "image" into "repository" and "tag" in both the Rook Ceph Operator and Cluster charts.

What is use case behind this feature:

As I am using my own private image registry, I need to modify the image repository in the values of my helm-chart. Since the tag is also specified in this same section, this makes it impossible for me to go with the default tags in case of an upgrade. I would then need to manually update the tags of every image for every upgrade. Separating "image" into "repository" and "tag" would make it much easier for people using a private registry to apply new versions.

Environment:

Any environment using a private image registry.

@travisn
Copy link
Member

travisn commented Jan 18, 2024

The separate repository and tag settings are already available in the operator chart values. Are you referring to the cephVersion.image in the cluster chart?

@krishau99
Copy link
Author

I was thinking about the other image definitions, cephcsi, registrar, resizer, etc. I believe these are defined in the operator chart, is there any reason that these aren't separated as well?

@travisn
Copy link
Member

travisn commented Jan 19, 2024

Ah, the csi images. It would keep things simpler the way defaults are handled for the csi images, but I don't see anything preventing them from being separated either. @Madhu-1 ?

@Madhu-1
Copy link
Member

Madhu-1 commented Jan 22, 2024

Ah, the csi images. It would keep things simpler the way defaults are handled for the csi images, but I don't see anything preventing them from being separated either. @Madhu-1 ?

Yes correct we can do it, i would also suggest making ImagePullPolicy as also configurable for csi images as well :)

@Javlopez Javlopez self-assigned this Jan 24, 2024
Copy link

github-actions bot commented Apr 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants