[RF] Fix debug build

hahnjo · hahnjo · commit 46db606a17f6 · 2022-03-29T11:05:00.000+02:00
Commit ff86c30 ("[RF] Implement SumW2 correction in new BatchMode with RooFitDriver") introduced some static constexpr. When building without compiler optimizations, the build fails with an "undefined reference to ROOT::Experimental::RooNLLVarNew::weightVarName" because the compiler attempts to use the external symbol of that variable when passing to a reference of a pointer. Resolve the issue by calling the constructor directly instead of std::make_unique.
diff --git a/roofit/roofitcore/src/BatchModeHelpers.cxx b/roofit/roofitcore/src/BatchModeHelpers.cxx
@@ -95,7 +95,7 @@ RooFit::BatchModeHelpers::createNLL(RooAbsPdf &pdf, RooAbsData &data, std::uniqu
    if (data.isWeighted()) {
       // RooRealVar for the weight value (or values as a batch) that will
       // participate in the computation graph of the RooFit driver.
-      weightVar = std::make_unique<RooRealVar>(RooNLLVarNew::weightVarName, "Weight(s) of events", data.weight());
+      weightVar.reset(new RooRealVar(RooNLLVarNew::weightVarName, "Weight(s) of events", data.weight()));
    }
 
    // Deal with the IntegrateBins argument

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ RooFit::BatchModeHelpers::createNLL(RooAbsPdf &pdf, RooAbsData &data, std::uniqu`
`95`	`95`	`if (data.isWeighted()) {`
`96`	`96`	`// RooRealVar for the weight value (or values as a batch) that will`
`97`	`97`	`// participate in the computation graph of the RooFit driver.`
`98`		`- weightVar = std::make_unique<RooRealVar>(RooNLLVarNew::weightVarName, "Weight(s) of events", data.weight());`
	`98`	`+ weightVar.reset(new RooRealVar(RooNLLVarNew::weightVarName, "Weight(s) of events", data.weight()));`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`// Deal with the IntegrateBins argument`