-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ntuple] Add tutorial for framework usage #16536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, LGTM! Perhaps invite a framework developer to take a look.
// A SerializingOutputter uses a sequential RNTupleWriter to append an RNTuple to a TFile and a std::mutex to | ||
// synchronize multiple threads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could add a note about IMT (or enable it), to show that page compression can still be in parallel even with the sequential mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this and unfortunately I think this is not possible / not efficient with the implementation in this tutorial: A thread blocking to acquire a std::mutex
cannot "help" the other thread that is currently in the critical section by executing its tasks. I added a note, also on the direct usage of std::thread
.
Test Results 14 files 14 suites 2d 21h 24m 31s ⏱️ Results for commit 122daf2. ♻️ This comment has been updated with latest results. |
Hi @Dr15Jones @makortel @siliataider, this PR aims to provide a tutorial how we (ROOT) envision frameworks could use the RNTuple API for writing. If you have some time, it would be great if you could check whether it makes sense and demonstrates the relevant use cases. The "framework code" is obviously very much simplified and the goal is not to code a full production framework, but I hope it's close enough to what the "real" experiment frameworks are doing. Thanks in advance! |
Closes #16290