Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.env with quoted values keeps the quotes when DEFINE'ing. #416

Closed
3 of 5 tasks
jawngee opened this issue Feb 14, 2019 · 4 comments
Closed
3 of 5 tasks

.env with quoted values keeps the quotes when DEFINE'ing. #416

jawngee opened this issue Feb 14, 2019 · 4 comments

Comments

@jawngee
Copy link

jawngee commented Feb 14, 2019

Submit a feature request or bug report

Replace any X with your information.


What is the current behavior?

I just did a fresh setup of the latest trellis + bedrock.

If the .env file has quoted values, eg:

DB_NAME='database_name'
DB_PASSWORD='example_dbpassword'
DB_USER='database_user'

Those values are defined in WordPress WITH the single quotes which is causing WordPress to fail to load.

The .env is generated by trellis/ansible with the single quotes, so I'm guessing the issue is with Bedrock's config loading stuff.

What is the expected or desired behavior?

The .env values are DEFINE'd without quotes.


Bug report

Please provide steps to reproduce, including full log output:

Literally all I did to reproduce:

  • Clone trellis
  • Clone bedrock
  • Set the domain/site names in the development group_vars
  • Vagrant up

Please describe your local environment:

Bedrock version: cfb68e1

WordPress version: 5.0.3

PHP version: 7.3

OS: Ubuntu 18.0something

Where did the bug happen? Development or remote servers?

Local development image

@jawngee
Copy link
Author

jawngee commented Feb 14, 2019

Updated phpdotenv to 3.3.6 fixes the issues.

@retlehs
Copy link
Member

retlehs commented Feb 14, 2019

i'm not seeing a 3.3.6 tag? https://github.com/vlucas/phpdotenv/releases

@jawngee
Copy link
Author

jawngee commented Feb 14, 2019

Sorry I meant 3.3.2

@retlehs
Copy link
Member

retlehs commented Feb 14, 2019

not sure why i can't re-produce, but the dependency has been bumped: #417

@retlehs retlehs closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants