-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] bud@16.4.1 incompatible with stylelint@15.10.1 #2365
Comments
I see that Stylelint has renamed the file from https://github.com/stylelint/stylelint/commits/main/bin/stylelint.mjs Edit: this needs to change (does it really need to be hardcoded?):
|
Right now bud.js ships with stylelint 5.9.0 and the command works with that binary. As you mentioned, you're on 5.10.x, and I can reproduce your issue under those conditions, but bud.js makes no guarantees about compatibility when you're rolling with your own dependencies. I think the bin path does need to be hardcoded because we can't guarantee the user will have a copy of stylelint resolvable as a peer dependency. It depends on the module resolution and hoisting strategies utilized by their package manager and how its configured.
All that said, some additional assurance that the binary is resolvable when constructing the proxied args array: #2367. |
Should be fixed in 6.14.2 https://github.com/roots/bud/releases/tag/v6.14.2 |
Agreement
Describe the issue
See below.
Expected Behavior
yarn bud lint css
should run successfully with stylelint@15.10.1 as defined in project manifest alongside@roots/bud-stylelint
. The command should have the same results asyarn stylelint resources/css/**/*.css
(assuming the usual Sage resource paths).Actual Behavior
When I run
yarn bud build
, the build appears to succeed. However, when I runyarn lint css
, bud fails entirely because it cannot find the stylelint executable:Steps To Reproduce
yarn add -D @roots/bud@6.14.1 @roots/bud-stylelint@6.14.1 stylelint@latest
yarn bud lint css
(bud fails to run stylelint)yarn bud build
(succeeds)version
6.14.1
Logs
Configuration
Relevant .budfiles
No response
The text was updated successfully, but these errors were encountered: