Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider alternatives to regexing HTML #1435

Closed
austinpray opened this issue Apr 24, 2015 · 1 comment
Closed

Consider alternatives to regexing HTML #1435

austinpray opened this issue Apr 24, 2015 · 1 comment

Comments

@austinpray
Copy link
Contributor

This is definitely pretty brittle. We should be using https://php.net/manual/en/book.dom.php here. Although I don't know enough about the community at large to know if this will cause problems for people. PHP Dom module is always enabled by default right? Need feedback.

@retlehs
Copy link
Member

retlehs commented Apr 24, 2015

irrelevant if #1427 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants