Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image location for pkgdown #260

Closed
maelle opened this issue Sep 2, 2022 · 7 comments
Closed

Fix image location for pkgdown #260

maelle opened this issue Sep 2, 2022 · 7 comments

Comments

@maelle
Copy link
Member

maelle commented Sep 2, 2022

Missing images in '/tmp/Rtmpy2xPLS/MODIStsp-source/index.md': 'reference/figures/irea_logo.png'pkgdown can only use images in 'man/figures' and 'vignettes' 

happy to help if needed!

@maelle
Copy link
Member Author

maelle commented Sep 2, 2022

What's the goal of this bot workflow, out of curiosity @ranghetti?

@ranghetti
Copy link
Contributor

I introduced the bot after a career change that did not allow me to continue providing assistance for the packages which I was maintaining. Currently I am limiting to strictly necessary package maintenance (e.g. #257). If it would be possible to have an help from rOpenSci community I would be happy to remove the bot (I would have deepen this topic as soon as I would have had time).
Regarding the issue, I will manage it as soon as possible.

@maelle
Copy link
Member Author

maelle commented Sep 5, 2022

Do you mean you'd need to recruit a co-maintainer? We could add a call for co-maintainer in the next newsletter. (or even a new maintainer if you'd prefer to step down -- thanks for your work on this package until now in any case) You could open an issue in this repo describing what tasks often occur, and we'd link to it. How would that sound?

@ranghetti
Copy link
Contributor

You could open an issue in this repo describing what tasks often occur, and we'd link to it. How would that sound?

@maelle thank you, I will move in this direction as soon as possible.

@maelle
Copy link
Member Author

maelle commented Sep 5, 2022

Thanks, please ping me when you've done that. 🙏

@ranghetti
Copy link
Contributor

In the meanwhile, last commit should have fixed the topic of this issue.
(Ps. I am also seeing this https://github.com/r-universe/ropensci/actions/runs/2977880182 , in which the error is not present even if the run is before the fix)

@maelle
Copy link
Member Author

maelle commented Sep 6, 2022

Yes this is a warning not a bug, but I reported it because missing images can be annoying. I saw it because there used to be an error too (#259). Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants