You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we can use in-memory memoization for self_hash(), as long as the memoized hashes do not carry over to the next make(). self_hash() seems to only be called inside dependency_hash(), so it is only used to get up-to-date hashes. If we can borrow some of those hashes across different targets, we will be in great shape.
Avoiding calls to config$cache$exists() turned out to not do much. Memoization can help, but we need to be careful. We should only memoize hashes if the targets are already checked and up to date, and we want to forget everything we memoized in the next session of make(). Even after that, there is danger. I tried this, and some of the tests still failed. Will attempt again at some point, hopefully soon.
Ref: #647. Ideas:
config$cache$exists()
.self_hash()
. How do we reuse hashes without having to read them again from the cache?The text was updated successfully, but these errors were encountered: