Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return early from some hashing functions if the input is empty #658

Closed
wlandau opened this issue Jan 6, 2019 · 0 comments
Closed

Return early from some hashing functions if the input is empty #658

wlandau opened this issue Jan 6, 2019 · 0 comments
Assignees
@wlandau
Labels
status: priority topic: performance
Milestone
Version 7.0.0

Comments

@wlandau
Copy link
Member

wlandau commented Jan 6, 2019

Ref #647. input_file_hash() and output_file_hash() are still calling digest() even when the target uses no files. These should return NA_character_ early. Same goes for dependency_hash().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlandau wlandau

Labels
status: priority topic: performance
Projects
None yet
Milestone
Version 7.0.0
Development

No branches or pull requests
1 participant
@wlandau