Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better approach to check if we need to download the data #119

Open
agila5 opened this issue Aug 22, 2020 · 3 comments
Open

A better approach to check if we need to download the data #119

agila5 opened this issue Aug 22, 2020 · 3 comments

Comments

@agila5
Copy link
Collaborator

agila5 commented Aug 22, 2020

See here: https://twitter.com/jakub_nowosad/status/1295030990121979908

@Robinlovelace
Copy link
Member

The pins package seems good but there are loads of options. What advantages were you thinking of from a user perspective? Benefit of our file.exists() approach from a developer perspective: simplicity.

@agila5
Copy link
Collaborator Author

agila5 commented Aug 24, 2020

What advantages were you thinking of from a user perspective

The main thing that I don't like with the current approach (but it's not a big deal I think) is that the user cannot modify the names of the files that are stored in the download_directory otherwise all the "assumptions" behind the oe_* functions are wrong. I know that this is not an important drawback (since I cannot think of any good reason to modify the names of those files).

The most important part was creating a "self-note" to study the principles behind caching (sooner or later), even if these ideas are not implemented here.

Maybe also related: ropensci/osmdata#159

@Robinlovelace
Copy link
Member

Makes sense, there could be advantages of using a caching framework/package rather than the simple approach we have and good to think about it. I think this is a discussion issue rather than a 'to do' issue and will mark it as such, if you think it's worth doing it would also get thumbs up from me if you think it's worth the extra dependency/code complexity.

@Robinlovelace Robinlovelace added enhancement New feature or request question Further information is requested discussion and removed enhancement New feature or request question Further information is requested labels Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants