Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type check logic, close #242 #243

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Update type check logic, close #242 #243

merged 2 commits into from
Jul 19, 2024

Conversation

Robinlovelace
Copy link
Member

No description provided.

@Robinlovelace Robinlovelace requested review from agila5 and layik July 19, 2024 05:03
@Robinlovelace Robinlovelace linked an issue Jul 19, 2024 that may be closed by this pull request
Better type guessing #242
Closed
@Robinlovelace
Copy link
Member Author

The issue was that grepl()'s first argument is pattern but we were assuming it was x.

That led to casu for example being treated as collision I think.

This should fix it, not 100% sure, hence request for review.

There are lots of other things we could improve but let's save for another PR.

agila5
agila5 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@agila5 agila5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Robinlovelace
Copy link
Member Author

Thanks for the test Layik and the review Andrea!

@Robinlovelace Robinlovelace merged commit 3242e36 into master Jul 19, 2024
6 checks passed
@Robinlovelace Robinlovelace deleted the 242-better-type-guessing branch July 19, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layik layik layik approved these changes

@agila5 agila5 agila5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better type guessing
3 participants
@Robinlovelace @layik @agila5