-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 235 #245
Conversation
ToDo:
I believe that is all needed to press "Ready for review" |
Looking really good. Many thanks Layik 🙏 |
… major NAs introduced
On a Win instance the issue seems to be at a simple get_stats19 call, Windows complains about invalid parameter type which makes no sense. Any help would be appreciated as the CI gives nothing to work with. 9. readr::cols(!!!col_types)
Quitting from lines 131-132 [dl2022-read] (stats19.Rmd)
Execution halted Session sessionInfo()
#> R version 4.4.1 (2024-06-14 ucrt)
#> Platform: x86_64-w64-mingw32/x64
#> Running under: Windows 10 x64 (build 19045)
#>
#> Matrix products: default
#>
#>
#> locale:
#> [1] LC_COLLATE=English_United Kingdom.utf8
#> [2] LC_CTYPE=English_United Kingdom.utf8
#> [3] LC_MONETARY=English_United Kingdom.utf8
#> [4] LC_NUMERIC=C
#> [5] LC_TIME=English_United Kingdom.utf8
#>
#> time zone: Europe/London
#> tzcode source: internal
#>
#> attached base packages:
#> [1] stats graphics grDevices utils datasets methods base
#>
#> loaded via a namespace (and not attached):
#> [1] digest_0.6.36 fastmap_1.2.0 xfun_0.46 glue_1.7.0
#> [5] knitr_1.48 htmltools_0.5.8.1 rmarkdown_2.27 lifecycle_1.0.4
#> [9] cli_3.6.3 reprex_2.1.1 withr_3.0.0 compiler_4.4.1
#> [13] rstudioapi_0.16.0 tools_4.4.1 evaluate_0.24.0 yaml_2.3.9
#> [17] rlang_1.1.4 fs_1.6.4 Created on 2024-07-29 with reprex v2.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion in the review, let's get this merged!
@@ -43,7 +43,7 @@ Casualty,accident_index,unique value for each accident. The accident_index combi | |||
Casualty,accident_reference,"In year id used by the police to reference a collision. It is not unique outside of the year, use accident_index for linking to other years",accident_reference,character | |||
Casualty,accident_year,NA,accident_year,numeric | |||
Casualty,age_band_of_casualty,NA,age_band_of_casualty,character | |||
Casualty,age_of_casualty,NA,age_of_casualty,character | |||
Casualty,age_of_casualty,NA,age_of_casualty,numeric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Awesome, thank you Layik! |
readr::read_csv
withstats19_variables$type
classes on readformat
function changing column types of the tibble/df's read inChecks?
Does this work with all types of objects supported by stats19?
closes #235