Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_tic(): Ensure that a DESCRIPTION file is present #200

Closed
2 tasks
pat-s opened this issue Dec 15, 2019 · 4 comments · Fixed by #213
Closed
2 tasks

use_tic(): Ensure that a DESCRIPTION file is present #200

pat-s opened this issue Dec 15, 2019 · 4 comments · Fixed by #213

Comments

@pat-s
Copy link
Member

pat-s commented Dec 15, 2019

Otherwise, macro functions will error during the CI run. See ropensci/software-review#305 (comment).

  • Assert a DESCRIPTION file in use_tic(). Create one if missing? Repo names with - are problematic.

  • Mention (more clearly) that build dependencies are installed from packages listed in the DESCRIPTION file

@pat-s pat-s mentioned this issue Jan 7, 2020
6 tasks
@krlmlr
Copy link
Collaborator

krlmlr commented Jan 13, 2020

Not sure we should require a DESCRIPTION for all projects.

@pat-s
Copy link
Member Author

pat-s commented Jan 13, 2020

How should step_install_deps() work otherwise?

@krlmlr
Copy link
Collaborator

krlmlr commented Jan 13, 2020

step_install_deps() raises an error if DESCRIPTION is missing, but the other steps don't.

@pat-s
Copy link
Member Author

pat-s commented Jan 13, 2020

Hm ok, I was just thinking that this step is basically within every pipeline and therefore we could quite early if DESC is missing (instead of waiting until the CI build arrives there and errors).
But there are just too many ways that one can get started with {tic} - we cannot safeguard all of them.

One could also argue why one would use {tic} without a proper pkg/project infrastructure.

I am with you that this is a very debatable change that also comes with some hurdles regarding the checking of this (which is imo also out of {tic}'s scope).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants