Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odd errors with sequence length queries at ncbi_byname #126

Open
kdlafferty opened this issue Jan 3, 2022 · 8 comments · May be fixed by #132
Open

odd errors with sequence length queries at ncbi_byname #126

kdlafferty opened this issue Jan 3, 2022 · 8 comments · May be fixed by #132
Labels

Comments

@kdlafferty
Copy link

"ncbi_byname" works great most of the time (thanks!), but with limited testing fails about 5%. Which makes searching long lists of species cumbersome. It seems like there are some sequences in ncbii that lead to glitches, and these can be avoided by limiting the length ranges. But it is otherwise unclear why some of these queries fail consistently and other succeed or how to add options to get around it.

I should specify that my goal is to get a longish sequence by gene/species combination. across many species and many genes (for metabarcoding primer selection).

In Rstudio.
ncbi_byname(taxa="Coryphaena hippurus", gene = c("Coi"), seqrange = "1:2000")#fails
ncbi_byname(taxa="Coryphaena hippurus", gene = c("Coi"), seqrange = "500:750")#fails
ncbi_byname(taxa="Coryphaena hippurus", gene = c("Coi"), seqrange = "600:2000")#works
ncbi_byname(taxa="Sardinops melanostictus", gene = c("12s"), seqrange = "1:2000")#fails
ncbi_byname(taxa="Sardinops melanostictus", gene = c("12s"), seqrange = "1:1000")#works
ncbi_byname(taxa="Sardinops melanostictus", gene = c("12s"), seqrange = "170:1000")#works
ncbi_byname(taxa="Sardinops melanostictus", gene = c("12s"), seqrange = "170:2000")#fails

@sckott
Copy link
Contributor

sckott commented Jan 3, 2022

👋🏽 previous maintainer here. this pkg is no longer maintained. you can still use it of course

@kdlafferty
Copy link
Author

thanks. Will use Rentrez instead.

@maelle
Copy link
Member

maelle commented Sep 9, 2022

This repository is about to be archived.

@maelle maelle closed this as completed Sep 9, 2022
@dlebauer
Copy link
Collaborator

👋🏻 new maintainer here: package is now unarchived

@dlebauer dlebauer reopened this Sep 13, 2022
@dlebauer
Copy link
Collaborator

This error still appears to occur in all of the examples above.

Is this worth resolving? e.g. do the ncbi_* functions still provide a value, or does the rentrez package provide the needed functionality, such that the ncbi_* functions in this package could be deprecated?

@boopsboops
Copy link
Contributor

boopsboops commented Oct 7, 2022

Is this worth resolving? e.g. do the ncbi_* functions still provide a value, or does the rentrez package provide the needed functionality, such that the ncbi_* functions in this package could be deprecated?

For what it's worth, I use ncbi_byid() function a lot because it returns a nice table. In fact I just noticed this thread when I came here to ask about how to best to fix the http version in the function because it now gives intermittent "Error in the HTTP2 framing layer" errors.

Might be related to OP's problem? Is it worth posting an issue about this?

@dlebauer dlebauer added the bug label May 18, 2024
@dlebauer dlebauer linked a pull request May 18, 2024 that will close this issue
@dlebauer
Copy link
Collaborator

Sorry this took so long. This should be resolved in PR #132

To test it out while the PR is still open:

install.packages("remotes")
remotes::install_github("ropensci/traits@129_ncbi_byname_error") 

If someone checks that this works, that would be much appreciated.

And double points if you are able to provide feedback on the PR!

@dlebauer
Copy link
Collaborator

@boopsboops if you found an error with ncbi_byid to report, please do! It would be good to have it documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants