-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase test coverage #291
Comments
What is the coverage when tests are run locally (i.e. ChemSpider is not skipped)? Might not be an issue, or might be a (somewhat) easy fix by adding a ChemSpider API token as a GitHub secret, then un-skipping those tests on CI. |
I might ask for some help there, if I run |
I can give it a try later this week. |
Local test coverage (with chemspider) is ~ 80%. But utils.R has lowest coverage, so boosting is probably a better idea than having chemspider tests run on CI. |
webchem's test coverage has fallen lately. The rOpenSci policy is 75% so let's bring it up to at least 75%.
https://devguide.ropensci.org/building.html#testing
The text was updated successfully, but these errors were encountered: