Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix for RealtimePublisher with NON_POLLING #85

Merged
merged 9 commits into from
Oct 1, 2022
Merged

bug fix for RealtimePublisher with NON_POLLING #85

merged 9 commits into from
Oct 1, 2022

Conversation

YoavFekete
Copy link
Contributor

its a fix bug for the issues reported in #43 and #82
added a new unit tests that test the Non)Polling version

@YoavFekete YoavFekete mentioned this pull request Aug 17, 2022
Open
destogl
destogl approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. When do we want to use this?

include/realtime_tools/realtime_publisher.h Outdated Show resolved Hide resolved
test/realtime_publisher_tests_non_polling.cpp Outdated Show resolved Hide resolved
@YoavFekete
Copy link
Contributor Author

@bmagyar any idea when and if this will be merged?
i want to continue to work on the publisher refactoring, but i gues bteer first finish with this

@YoavFekete
Copy link
Contributor Author

@destogl ok i think fixed all the workflow run errors . can u please rerun the tests

@YoavFekete
Copy link
Contributor Author

@destogl ok i think fixed all the workflow run errors . can u please rerun the tests

ok lets try again

@destogl destogl requested a review from bmagyar October 1, 2022 07:26
@bmagyar bmagyar merged commit 0d6b397 into ros-controls:master Oct 1, 2022
@christophfroehlich christophfroehlich mentioned this pull request Jan 22, 2024
Closed
@christophfroehlich christophfroehlich mentioned this pull request Nov 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@destogl destogl destogl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YoavFekete @destogl @bmagyar