-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Flip / Mirror (FFMV USB) #47
Comments
The current master branch of the driver source allows external ROS nodes to get and set register values via new This new feature is not yet documented or released. Would you please build the driver from source and test whether that interface works for your application? |
Flipping the image can be done in software, but is probably better done outside camera1394, or any other specific camera driver. If you want to pursue that approach, I would recommend writing a generic "image flipper" nodelet that can do the job for any image stream. That could be added to |
Yep. I'm happy to do both these approaches and report back ;) A generic image_flipper nodelet would indeed be very useful. Thanks for the help!! |
@jack-oquin I think I've mostly got it. The value[] that the Get service call returns is a bitmask,if I'm correct. So I should be able to modify bit 23 by - getting the value from the register, making value[23] whatever I desire, and writing the value back? |
I didn't write that code, and it is still not documented. That is the main reason why it has not yet been released. I think you have the general idea. The Get returns the contents of some particular register, and the Set changes its value. This feature was mostly introduced to support various non-standard Point Grey interfaces without adding non-standard code to the camera1394 driver. Maybe if you figure out how to use it, you can help me document it. I don't own any of those cameras, making it hard for me to test. |
Hi,
Having the ability to flip or mirror a image from a camera would be very useful (I'm using a FireFly MV on the USB bus) and our hardware mounting is such that I need one camera flipped horizontally.
According to PointGrey's Register Reference, it can be enabled by setting the register IMAGE_DATA_FORMAT(0x1048) , bit 23 to 1 or 0 as required. It will do image flip on-camera in DMA buffers.
https://pixhawk.ethz.ch/_media/dev/electronics/cameras/point_grey_digital_camera_register_reference.pdf
If this change isn't something that can be adapted to mainstream, I'm willing to do it myself, but would like some help on where and how to implement it best. Otherwise, if this can be implemented in software in the driver itself, that'd be awesome too, and would benefit all camera types.
Thanks,
Kabir
The text was updated successfully, but these errors were encountered: