Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with sensor on firmware v2.4 #116

Closed
vinnnyr opened this issue Oct 14, 2022 · 5 comments
Closed

Does not work with sensor on firmware v2.4 #116

vinnnyr opened this issue Oct 14, 2022 · 5 comments

Comments

@vinnnyr
Copy link
Contributor

vinnnyr commented Oct 14, 2022

Details / logs to come. Just a warning I wanted to post right now to users of the repo that as of the latest commit on ros2 (cdd7786) , to not upgrade until this is resolved, since it is not possible to revert to firmware v2.3 (they disabled the download on the website).

From what I understand, this is due to some deprecated parameters in the new firmware (auto_start_flag and udp_ip).

I am working on a fix, and will try to PR it when I have tested it against the new firmware, however I am not really sure how backwards compatible it will be.

@vinnnyr
Copy link
Contributor Author

vinnnyr commented Oct 19, 2022

From Ouster, this is the patch that would work for 2.4 on their version of the driver.
ouster-lidar/ouster-sdk@6e3df5e

@SteveMacenski would you be ok with a PR back here with the content of that diff? The only thing is that pushing for firmware 2.4 compatiblity might break compatible with earlier firmwares

@kpsgf7
Copy link

kpsgf7 commented Oct 19, 2022

@vinnnyr Are you attempting a fix for this then? I may attempt a fix if we are unable to get v2.3 of the firmware from Ouster. Would love to contribute if that's something that would be helpful here.

@vinnnyr
Copy link
Contributor Author

vinnnyr commented Oct 19, 2022

@kpsgf7 can you test this fork? https://github.com/fireflyautomatix/ros2_ouster_drivers/tree/fix-for-firmware-2.4

I currently don't have a lidar with v2.4 to test on available to me, hence my hesitation in opening the PR. I should have one available to me shortly

@vinnnyr
Copy link
Contributor Author

vinnnyr commented Oct 20, 2022

I just tested this with 2 v2.4 lidars. I think that PR should be ready for review now!

@kpsgf7
Copy link

kpsgf7 commented Oct 20, 2022

This worked for us! Thank you! We really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants