Switch to a const AVCodec *. #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because newer versions of avcodec return a const AVCodec *. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
Rolling CI failing due to this issue: ros-tooling/action-ros-ci#844 (comment) EDIT: in the last two weeks it looks like the new docker image is available now, so re-running the pipeline now should pass since it'll now pick up the |
|
The noble image is now correctly picked up for the rolling job, however it looks like some deps are still not fully ready for prime time yet on the new 24.04 distro. I'll go ahead and merge this in so that once the deps are available for rosdep itll correctly pull them in |
|
@flynneva Thanks for merging! Yeah, we are still waiting for some dependencies to rebuild in Noble. Once that happens, this should fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because newer versions of avcodec return a const AVCodec *.
This should fix the build on Ubuntu 24.04, like in https://build.ros2.org/view/Rbin_uN64/job/Rbin_uN64__usb_cam__ubuntu_noble_amd64__binary/ . I also compile tested it on Ubuntu 22.04, and it worked find there as well.