-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use intrinsics from CameraInfo message? #25
Comments
Definitely possible and desirable. This would require some modifications to Yak to associate camera intrinsics with each image rather than loading them from a class-member parameter variable. Ideally this change would be designed to allow data from multiple cameras to be integrated into the volume simultaneously. Another improvement would be using the distortion coefficients provided on the Since these features would require changes to Yak I'll make an enhancement issue in the Yak repo as well. |
This would certainly be nice, but I was thinking of a first simple enhancement using ros::topic::waitForMessage(..) to retrieve a single |
I think that would be really straightforward. If there isn't a |
Yes, that would make sense to maintain current behaviour. |
The current implementation of
yak_ros
requires users to provide the relevant camera intrinsics via thecamera_matrix
ROS parameter.I'm wondering whether it would be possible to instead retrieve a message from the
camera_info
topic from the same namespace as the depth image.Afaict (but I'm not a "vision guy"), the
K
field of the message contains the requiredfx
,fy
,cx
andcy
. It also contains the resolution (width
andheight
fields).The text was updated successfully, but these errors were encountered: