Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake project support? #126

Closed
130s opened this issue Feb 14, 2017 · 9 comments
Closed

cmake project support? #126

130s opened this issue Feb 14, 2017 · 9 comments

Comments

@130s
Copy link
Member

130s commented Feb 14, 2017

Just got a question if industrial_ci supports cmake, non catkin package (I assume something still related to ROS. E.g. ROS QtCreator plugin) from @Levi-Armstrong.

I wouldn't say we would plan to support cmake project, at least for now, given industrial_ci is currently tied to catkin_tools. But I'll leave this open for discussion.

@mathias-luedtke
Copy link
Member

If catkin_tools support plain cmake packages, industrial_ci supports it as well.

@gavanderhoorn
Copy link
Member

@ipa-mdl wrote:

If catkin_tools support plain cmake packages [..]

according to the docs (Workspace Mechanics - Source Packages and Dependencies) it does not.

@mathias-luedtke
Copy link
Member

mathias-luedtke commented Feb 14, 2017

according to the docs (Workspace Mechanics - Source Packages and Dependencies) it does not.

It should work for cmake projects with proper package.xml.
The default source test does not work for for non-catkin packages.
What should get tested for bare cmake projects?

However, it should be possible to choose or provide other tests (#98)

@gavanderhoorn
Copy link
Member

@ipa-mdl wrote:

It should work for cmake projects with proper package.xml.

true, but I would not call that a 'plain cmake' package anymore.

ament changes this.

@wxmerkt
Copy link
Contributor

wxmerkt commented Apr 21, 2019

I have a plain-CMake project that is wrapped into ROS as an external library via a package.xml and <buildtype>cmake</buildtype>. Catkin builds it just fine and industrial-ci does so too, but it tries to test and of course can't find the output directories for catkin_test_results ... - hence it fails in PRERELEASE mode. Is there a workaround for this I am unaware of?

@mathias-luedtke
Copy link
Member

hence it fails in PRERELEASE mode. Is there a workaround for this I am unaware of?

Prerelease just wraps https://github.com/ros-infrastructure/ros_buildfarm, not sure if it supports plain cmake packages

can't find the output directories for catkin_test_results

This should not show an error.
catkin_test_results just crawls for xunit reports and dispays their errors found in there.
No xunit file, no error:

Summary: 0 tests, 0 errors, 0 failures, 0 skipped

@wxmerkt
Copy link
Contributor

wxmerkt commented Apr 21, 2019

I may have misinterpreted the travis result/error - the build I am referring to is here

@mathias-luedtke
Copy link
Member

I may have misinterpreted the travis result/error - the build I am referring to is here

No, you did not..
It looks like the the ros_buildfarm scripts passes a directory that is not exisiting.
NOT_TEST_INSTALL and NOT_TEST_BUILD are not used in prerelease test.
I have opened a new issue make this configurable (#362)

You could try the new version (#361), it uses the latest ros_buildfarm version from source,.
If the error persists, you shoud open an issue over there.

@mathias-luedtke
Copy link
Member

colcon support plain cmake project, so it should work with the new master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants