Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Staging" industrial_ci? #263

Open
130s opened this issue Jan 13, 2018 · 3 comments
Open

"Staging" industrial_ci? #263

130s opened this issue Jan 13, 2018 · 3 comments

Comments

@130s
Copy link
Member

130s commented Jan 13, 2018

Gitlab CI allows staging to split CI jobs per e.g. build, test, deploy. This sounds quite convenient in many ways. I haven't looked into if other CI platform has this feature.

To utilize this I think we have to at least split our procedure in industrial_ci/src/tests/source_tests.sh, provide an api to selectively run each CI step.

@130s
Copy link
Member Author

130s commented Jan 13, 2018

This may be already noted in #98. If it is, then that proves this isn't a bad idea :)

@mathias-luedtke
Copy link
Member

This is rather tricky to accomplish, due to using Docker and making it work for all the different tests we have.
It would require a major refactoring and in the end we will end up with something that works like the ROS prerelase tests.

Don't get me wrong, I like the idea of stages, but it might be hard to make this backwards-compatible.
And it bloats the CI config files.

PS: Travis started to support stages (beta) as well.

@frapit
Copy link

frapit commented Oct 4, 2021

Since this is still an open issue and stages or similar concepts are supported by Gitlab, Travis and Github for a while now I would like to ask if there are plans to pursue this further.
I think one can get similar functionality by building first using NOT_TEST_BUILD and PYLINT_CHECK and commiting the container after each "stage" to reuse the build cache later. This seems to be a bit hacky and I would prefer a cleaner solution.

Don't get me wrong, I like the idea of stages, but it might be hard to make this backwards-compatible.
And it bloats the CI config files.

Is the consequence that we don't want stages or is this obsolete? What would need to be refactored to support this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants