Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analog output domain in setIO service #11

Closed
fmauch opened this issue Feb 15, 2021 · 11 comments · Fixed by #28
Closed

Analog output domain in setIO service #11

fmauch opened this issue Feb 15, 2021 · 11 comments · Fixed by #28
Assignees

Comments

@fmauch
Copy link
Contributor

fmauch commented Feb 15, 2021

Currently, the setIO service does not support specifying the domain (voltage / current) when setting an analog output. This should be included. Before creating a PR, I'd like to clarify whether it might be worth it, splitting the setIO service into multiple services, as there are quite different things this service does handle. We have the Analog.msg and Digital.msg messages already that contain the necessary fields. With defining individual services we could reuse them directly instead of adding yet another (optional) field to the setIO service.

In the current ur_robot_driver implementation we unpack the service request anyway and call different functions depending on the request's content.

@mohamedamrali1993
Copy link

Hi, Is there any update on this issue? I need to control the AO pins' voltage between 0 and 24 volts. I know the setIO is a big srv file but if we add a field for AO voltage vs. current, it would be better than not having it at all. As of now, I am not sure if the Analog and Digital msgs are useful, what topic do they work with? I am guessing you want to couple those messages in addition to the setIO service? Thanks for all of your contributions to the ROS driver!

@fmauch
Copy link
Contributor Author

fmauch commented Mar 9, 2022

There has been no update on this matter, so far.

@zp2546265641
Copy link

There has been no update on this matter, so far.

Hello, thank you for your help yesterday, but now I also encounter this problem, how can I set the voltage of AO, every time I send a request, it becomes current instead of voltage, at the same time the current is changed by the proportion, but the voltage is still 0V (0-10V). Unfortunately, my proportional valve shows "error" under the current signal, and it only supports voltage input 0-10v.

@fmauch
Copy link
Contributor Author

fmauch commented Jul 18, 2024

I was just about to refer this issue in UniversalRobots/Universal_Robots_ROS_Driver#709

@zp2546265641
Copy link

Hi, Is there any update on this issue? I need to control the AO pins' voltage between 0 and 24 volts. I know the setIO is a big srv file but if we add a field for AO voltage vs. current, it would be better than not having it at all. As of now, I am not sure if the Analog and Digital msgs are useful, what topic do they work with? I am guessing you want to couple those messages in addition to the setIO service? Thanks for all of your contributions to the ROS driver!

Hello, now I also encounter this problem, how can I set the voltage of AO, every time I send a request, it becomes current instead of voltage, at the same time the current is changed by the proportion, but the voltage is still 0V (0-10V). Unfortunately, my proportional valve shows "error" under the current signal, and it only supports voltage input 0-10v.

and then, how do you solve such problem?

@zp2546265641
Copy link

I was just about to refer this issue in UniversalRobots/Universal_Robots_ROS_Driver#709

hi, I just happened to search for this question and came here, and does such issue have some solve solutions?

@zp2546265641
Copy link

I was just about to refer this issue in UniversalRobots/Universal_Robots_ROS_Driver#709

i use '/ur_hardware_interface/script_command' is ok, but this will cause the problem of external control interruption.

@fmauch fmauch self-assigned this Jul 18, 2024
@fmauch
Copy link
Contributor Author

fmauch commented Jul 18, 2024

I'll try to implement something...

@zp2546265641
Copy link

I'll try to implement something...

thank you very much! great work you do! i hope for your good messgae!

@fmauch
Copy link
Contributor Author

fmauch commented Sep 19, 2024

We should also do that for ROS 2

@fmauch
Copy link
Contributor Author

fmauch commented Oct 7, 2024

Implemented and merged in #30

@fmauch fmauch closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants