Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bloom should not allow me to release packages with a bad name. #191

Closed
ahendrix opened this issue Jul 15, 2013 · 1 comment
Closed

Bloom should not allow me to release packages with a bad name. #191

ahendrix opened this issue Jul 15, 2013 · 1 comment
Milestone

Comments

@ahendrix
Copy link

I recently released pr2_etherCAT into Hydro. Unfortunately, ros-hydro-pr2-etherCAT is not a valid debian package name (capital letters don't appear to be allowed), so the source deb build has been failing. I think bloom should not allow this to happen.

Possible fixes:

  1. Translate package names to all lowercase before releasing.
  2. Don't allow the release of packages with invalid names.

I'm personally in favor of 1 since it doesn't require me to rename my package, but I suspect it entails a fair amount of modification to the ROS tools to support it.

@wjwwood
Copy link
Contributor

wjwwood commented Jul 15, 2013

Rather than lower case the name, I think bloom will just refuse to release the repository. I will open a ticket to get this check into catkin_prepare_release also.

The reasons for not automatically lower casing the package name:

I will leave this ticket open until I have a check for this in bloom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants