Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be possible to chose with what to replace 'error values' for LaserScanBoxFilter? #165

Open
cantolini opened this issue Aug 23, 2022 · 1 comment

Comments

@cantolini
Copy link

When using the LaserScanBoxFilter, we don't have a choice on the replacement of the values inside the filtered box. With this type of filter, the values are replaced by NaN. For my application, I would like to be able to have them replaced by something else.
This can already be done for other filters such as the LaserScanRangeFilter with the upper/lower_replacement_value.

So is there a way we could be able to have the choice of the replacement value for the LaserScanBoxFilter filter too?

(I am using ROS2 Galactic)

@jonbinney
Copy link
Contributor

Seems like a reasonable feature to add but I'm short on time - could you submit a PR that adds it? To do this you'd need to:

The default value for the parameter should be NaN so that the default behavior doesn't change for anyone currently using the filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants