Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default replacement values #172

Open
borongyuan opened this issue Nov 22, 2022 · 0 comments
Open

Wrong default replacement values #172

borongyuan opened this issue Nov 22, 2022 · 0 comments

Comments

@borongyuan
Copy link

borongyuan commented Nov 22, 2022

Hi,
I found the default value of lower_replacement_value and upper_replacement_value in LaserScanRangeFilter is 0, not NaN.
This is caused by the implementation of getParam().

bool getParam(const std::string & name, double & value)
  {
    return getParamImpl(name, rcl_interfaces::msg::ParameterType::PARAMETER_DOUBLE, 0.0, value);
  }

This may also affect other filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant