Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convention for calling filter plugins not followed in all files #69

Open
YoshuaNava opened this issue Feb 28, 2019 · 0 comments
Open

Convention for calling filter plugins not followed in all files #69

YoshuaNava opened this issue Feb 28, 2019 · 0 comments

Comments

@YoshuaNava
Copy link

Hi,
I'm a user of the filters, and after switching to ROS Melodic I'm getting warnings about the laser filter files not specifying the parent owner of their plugins.

An example:

Bad filter type ScanShadowsFilter. Filter type must be of form <package_name>/<filter_name>

I've checked the files in your repo, and noticed that one of the yaml files complies with the <package_name>/<filter_name> convention, while most of the other files do not.

Indigo is EOL in a month, and I think this package should remain compatible with newer versions. Hence, it would be good to update these files. I'll submit a PR with the relevant changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant