feat: AMCL Diagnostics #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostic task that monitors the estimated standard deviation of the filter.
DLu
reviewed
Nov 15, 2018
There was a problem hiding this comment.
This seems like a great change, but I would like to change the names of the variables. Rather than max_std_x, how would you feel about cov_warn_level_x. It's not great, and I'm open to suggestions. However, I feel like the current name doesn't reflect that the only thing it effects is the diagnostic status. Personally, I would have done covar instead of cov but we already have initial_cov_xx
Co-Authored-By: reinzor <reinzor@gmail.com>
|
For me the reason for specifying the standard deviation is that it is easier to understand the value you have to specify. What about |
|
Apologies for the delay. Those names work for me. |
|
Renamed to warn level |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnostic task that monitors the estimated standard deviation of the
filter.
Users can tweak the
max_std_x,max_std_yandmax_std_yawparameters according to their needs. A warning diagnostic message will be published if the standard deviation exceeds one of these limits.