Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows][melodic] AMCL Windows build bring up. #849

Merged
merged 2 commits into from
Apr 28, 2019

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Jan 31, 2019

  • Add HAVE_UNISTD and HAVE_DRAND48 and portable_utils.hpp for better cross compiling.
  • Variable length array is not supported in MSVC, conditionally disable it.
  • Fix install location for shared lib and executables on Windows.
  • Use isfinite for better cross compiling.

This change is verified against the https://aka.ms/ros project.

Sean Yen added 2 commits January 31, 2019 12:08
* Add HAVE_UNISTD and HAVE_DRAND48 and portable_utils.hpp for better cross compiling.
* Variable length array is not supported in MSVC, conditionally disable it.
* Fix install location for shared lib and executables on Windows.
* Use isfinite for better cross compiling.
@seanyen seanyen changed the title [Windows] AMCL Windows build bring up. [Windows][melodic] AMCL Windows build bring up. Feb 8, 2019
@seanyen
Copy link
Contributor Author

seanyen commented Apr 1, 2019

@DLu Hi! Hope I am pinging the correct maintainer. Can you take a look #849 #850 #851? Hope I get some feedbacks if it requires iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants