[melodic] updated install for better portability. #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikeferguson This is ready for review and merge. Thanks. |
|
Thanks! I don't know much about your windows release mechanism - do you need a new tagged release in order to actually use this? |
|
@mikeferguson Leave it at the upstream is fine for now. https://aka.ms/ros is building everything from upstream. Feel free to stick with the regular release cadence. Btw, I will be soon move my focus to |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to install the library to the correct location for Windows.
The change adheres with the catkin guide:
https://docs.ros.org/api/catkin/html/howto/format1/building_libraries.html#installing
https://docs.ros.org/api/catkin/html/howto/format1/building_executables.html#installing