Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadman not sending stop command (joy) #45

Open
glmnet opened this issue Jan 14, 2020 · 1 comment
Open

Deadman not sending stop command (joy) #45

glmnet opened this issue Jan 14, 2020 · 1 comment

Comments

@glmnet
Copy link

glmnet commented Jan 14, 2020

I might be doing something wrong, even looking at the source code I can't figure out how to get it to work like I want:

I press button, hold down, then move the robot around with joy axes, then stop axes, robot stops release button -> all is ok.
But if I'm moving the robot with the axes, then release the button, the robot keeps moving for a while until I believe my engine controller stops moving because it stops receiving cmd_vel commands, i.e. it never receives a cmd_vel with target velocity of 0.

I was using joy_teleop before and it worked this way, the cmd_vel 0 was sent on button release.

Now this teleop tools seems more flexible and useful for me.

In any case I can send a PR to support this if it will be welcomed.

Relevant config is just this:

teleop:
  joy_move:
    type: topic
    message_type: geometry_msgs/Twist
    topic_name: cmd_vel
    deadman_buttons: [4]
    axis_mappings:
      -
        axis: 1
        target: linear.x
        scale: 0.7
      -
        axis: 0
        target: angular.z
        scale: 0.5
@glmnet
Copy link
Author

glmnet commented Mar 5, 2020

I've sent a PR for this #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant