Action ignores failed rosdep install

[bjsowa]

Description

When rosdep fails to install some dependencies, the action does not fail and instead tries to build the packages anyway.

Expected Behavior

I would expect the action to fail or at least an option to choose whether the action should fail fast.

Actual Behavior

The action does not fail.

[christophebedard]

We do indeed do || true with rosdep install to avoid making it fail the action:

action-ros-ci/src/action-ros-ci.ts

Line 188 in fcaebb7

)}" --rosdistro $DISTRO -y || true`;

It looks like this has been here since the very beginning: 6de5bca

In what instances is rosdep install failing for you?

[bjsowa]

In what instances is rosdep install failing for you?

I was trying to release my packages to Jazzy and incorrectly assumed all dependencies correctly resolve because the CI was passing.

[christian-rauch]

I am encountering the issue too and would prefer if the action fails if rosdep fails. There is rosdep-skip-keys to skip certain rosdep keys, but the action should fail if non-skipped keys cannot be resolved.

[christophebedard]

So the original implementation had this comment:

action-ros-ci/lib/action-ros2-ci.js

Lines 46 to 47 in 6de5bca

	// For "latest" builds, rosdep often misses some keys, adding "|| true", to
	// ignore those failures, as it is often non-critical.

And the current code has this comment:

action-ros-ci/src/action-ros-ci.ts

Lines 200 to 202 in 58bf65b

	# suppress errors from unresolved install keys to preserve backwards compatibility
	# due to difficulty reading names of some non-catkin dependencies in the ros2 core
	# see https://index.ros.org/doc/ros2/Installation/Foxy/Linux-Development-Setup/#install-dependencies-using-rosdep

That being said, those two explanations don't make much sense to me. Could you give #910 a try? I just wonder if there are still cases where rosdep install could fail for a "good" reason, even if that doesn't really make sense.