cmake qt5 cleanup #1008
Merged
cmake qt5 cleanup #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use a common variable QT_LIBRARIES to pull in lib dependencies, both in Qt4 and Qt5 use a common variable QTVERSION
|
Thanks for the patch, I think it would a good improvement. Looks like CI is failing though, and I don't have time to address the issue at the moment, so it would be a while before I can fix it up. |
|
Oops. I missed one dependency. Sorry. |
|
Thanks, lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify QT usage in cmake files for both Qt4 and Qt5 version by setting common variables once.