Allow disabling RViz splash-screen #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hate splash screens.
setSplashPathexplains that the user can disable the splash screen by setting an empty path:https://github.com/ros-visualization/rviz/blob/kinetic-devel/src/rviz/visualization_frame.h#L87-L91
But the user can't because if the splash screen path argument is empty, the function is not called:
https://github.com/ros-visualization/rviz/blob/kinetic-devel/src/rviz/visualizer_app.cpp#L277-L280
This PR fixes the behavior: