map_display: don't ignore resolution changes in OccupancyGrid maps #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I've noticed that changes of resolution to an occupancy grid map are not correctly reflected in RViz. I've investigated the
map_displayplugin code and noticed thatcreateSwatches()inMapDisplay::showMap()is only called when the width or height changes, but not the resolution. I therefore extended theif(width != width_ || height != height_){ ...accordingly. Note that changing resolutions are (still) correctly reflected in RViz' UI panel.I've tested this in ROS Kinetic and it works like a charm. Would be great if you merge my PR upstream. Thank you!