Avoid unnecessary addPoints in PointCloudCommon::update #1122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding new points to the PointCloud, setRenderMode call regenerateAll which remove all points and add then again (to apply the new render mode).
As the PointCloud is just created, it is empty. So calling setRenderMode before addPoints avoid the regeneration and improve performance.
This is an easy performance improvement, there a lot a copying in this plugin that hurt perf, with patterns like allocating a lot of memory to throw it right away from each new incoming pointcloud (or depth_cloud). I might find some time to dig more deeply into it.